{"id":39,"date":"2009-08-15T05:26:22","date_gmt":"2009-08-15T12:26:22","guid":{"rendered":"http:\/\/journeyman.ivystreetinc.com\/?p=39"},"modified":"2009-11-13T05:29:05","modified_gmt":"2009-11-13T12:29:05","slug":"the-code-review","status":"publish","type":"post","link":"http:\/\/10kdev.net\/?p=39","title":{"rendered":"The Code Review"},"content":{"rendered":"<p>I like code reviews now days, done right.<\/p>\n<p>Code reviews help to:<\/p>\n<ul>\n<li>Add to the support base of the code.<\/li>\n<li>Normalize the development techniques on the codebase.<\/li>\n<li>Add to team cohesiveness.<\/li>\n<li>Help developers develop presentation and communication skills.<\/li>\n<li>Force that last 5% execution of the writing of the code.<\/li>\n<li>Improve code quality and developer skillsets.<\/li>\n<\/ul>\n<p>I&#8217;ve been and hosted in several different types of reviews:<\/p>\n<ul>\n<li>Scheduled weekly meeting.<\/li>\n<li>Present-as-it-emerges.<\/li>\n<li>Sprint-end code reviews (in Agile).<\/li>\n<\/ul>\n<p>For these reviews to be successful, I find that these rules of thumb are essential:<\/p>\n<ul>\n<li>Developers only.<\/li>\n<li>DEVELOPERS ONLY.<\/li>\n<li>A place to present; such as a meeting room or a quiet bullpen.<\/li>\n<li>Projects rule!<\/li>\n<li>Master of Ceremonies: Let the architect MC, a lead dev MC, or rotate through MC duties.<\/li>\n<li>Everyone should try to present at some time. Many times there are pairs where a stonger personality will always present.\u00a0 Hogwash.\u00a0 This doesn&#8217;t help the other developer at all.<\/li>\n<li>Food is a good thing to have there.<\/li>\n<li>This meeting can last a long time, hours, depending on which review style you use.<\/li>\n<\/ul>\n<p>Some may disagree with the developers only rule.\u00a0\u00a0 But it is essential; this is not functional review its code review and its all about the developers.\u00a0 Other points of view will create a conflict of interest, especially management, and the goal of the meeting will fail.<\/p>\n","protected":false},"excerpt":{"rendered":"<p>I like code reviews now days, done right. Code reviews help to: Add to the support base of the code. Normalize the development techniques on the codebase. Add to team cohesiveness. Help developers develop presentation and communication skills. Force that last 5% execution of the writing of the code. Improve code quality and developer skillsets. [&hellip;]<\/p>\n","protected":false},"author":2,"featured_media":0,"comment_status":"closed","ping_status":"open","sticky":false,"template":"","format":"standard","meta":[],"categories":[4],"tags":[],"_links":{"self":[{"href":"http:\/\/10kdev.net\/index.php?rest_route=\/wp\/v2\/posts\/39"}],"collection":[{"href":"http:\/\/10kdev.net\/index.php?rest_route=\/wp\/v2\/posts"}],"about":[{"href":"http:\/\/10kdev.net\/index.php?rest_route=\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"http:\/\/10kdev.net\/index.php?rest_route=\/wp\/v2\/users\/2"}],"replies":[{"embeddable":true,"href":"http:\/\/10kdev.net\/index.php?rest_route=%2Fwp%2Fv2%2Fcomments&post=39"}],"version-history":[{"count":5,"href":"http:\/\/10kdev.net\/index.php?rest_route=\/wp\/v2\/posts\/39\/revisions"}],"predecessor-version":[{"id":44,"href":"http:\/\/10kdev.net\/index.php?rest_route=\/wp\/v2\/posts\/39\/revisions\/44"}],"wp:attachment":[{"href":"http:\/\/10kdev.net\/index.php?rest_route=%2Fwp%2Fv2%2Fmedia&parent=39"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"http:\/\/10kdev.net\/index.php?rest_route=%2Fwp%2Fv2%2Fcategories&post=39"},{"taxonomy":"post_tag","embeddable":true,"href":"http:\/\/10kdev.net\/index.php?rest_route=%2Fwp%2Fv2%2Ftags&post=39"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}